Skip to content

Always enable expect 100-continue on cross region#7057

Merged
dagnir merged 1 commit into
masterfrom
dongie/expect-100-continue-s3-crossregion
Jun 22, 2026
Merged

Always enable expect 100-continue on cross region#7057
dagnir merged 1 commit into
masterfrom
dongie/expect-100-continue-s3-crossregion

Conversation

@dagnir

@dagnir dagnir commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

When making cross region streaming calls on S3, we need to have the 'Expect: 100-continue' header set to avoid I/O errors from sending the body unconditionally to S3 resulting in responding with a 3xx and termining the connection while the client is still writing the object.

Modifications

If cross region access is enabled, always set Expect: 100-continue for PutObject/UploadPart.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner June 19, 2026 23:37
@dagnir dagnir added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Jun 19, 2026
@dagnir

dagnir commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Added no-api-surface-area-change tag since it's just a doc update.

Comment thread services/s3/src/main/java/software/amazon/awssdk/services/s3/S3Configuration.java Outdated
@dagnir dagnir force-pushed the dongie/expect-100-continue-s3-crossregion branch from 1a92500 to 87289f2 Compare June 22, 2026 18:53
When making cross region streaming calls on S3, we need to have the
'Expect: 100-continue' header set to avoid I/O errors from sending the
body unconditionally to S3 resulting in responding with a 3xx and
termining the connection while the client is still writing the object.
@dagnir dagnir force-pushed the dongie/expect-100-continue-s3-crossregion branch from 87289f2 to 552d8e4 Compare June 22, 2026 18:57
@dagnir dagnir enabled auto-merge June 22, 2026 18:59
@dagnir dagnir disabled auto-merge June 22, 2026 22:35
@dagnir dagnir added this pull request to the merge queue Jun 22, 2026
Merged via the queue into master with commit bb87b28 Jun 22, 2026
12 of 13 checks passed
@github-actions

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants